Merged
Conversation
Contributor
Author
|
Ok, just spotted that I should hook this to the main view as well. I'll look at doing that next week. |
koesie10
approved these changes
Sep 26, 2022
Contributor
Author
|
@koesie10, I've pushed a couple more commits, if you could re-review. I've adjusted the styling to fit better with how we do it in other components, and also to add some padding because it looked bad without it. I've also hooked it into the main variant analysis component, and it would be shown if you don't set the action workflow ID. I haven't made it so you can view both states in the story book because currently the variant analysis component doesn't take any props, but that could be something to do in the future. |
koesie10
approved these changes
Sep 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a component to show when the variant analysis submission is being processed. This component doesn't have any props as there's only state it needs to show. The decision on whether to show it or not based on the variant analysis status will be decided by the parent component.
Storybook screenshot:
See the internal issue for how it's meant to look. I've tried to copy the style as closely as possible but please do tell me if this could fit in better.
Checklist
ready-for-doc-reviewlabel there.